Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent moving panels out of sight #752

Merged
merged 2 commits into from
Dec 3, 2021
Merged

Prevent moving panels out of sight #752

merged 2 commits into from
Dec 3, 2021

Conversation

lmoureaux
Copy link
Contributor

Closes #751.

Test plan:

  • Start game
  • Move widgets around, trying to make them leave the visible area:
    • Minimap
    • Upper left info widget
    • Chat
    • Unit info

jwrober
jwrober approved these changes Dec 3, 2021
View reviewed changes
Copy link
Collaborator

@jwrober jwrober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@lmoureaux lmoureaux merged commit d0e9eb3 into longturn:master Dec 3, 2021
@lmoureaux lmoureaux deleted the bugfix/move-panels-outside-window branch December 3, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwrober jwrober jwrober approved these changes

@psampathkumar psampathkumar Awaiting requested review from psampathkumar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't allow moving panel handles out of the screen
2 participants
@lmoureaux @jwrober