Break infinite update() loop in sidebar #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resulted from misuse of the Qt APIs. Use them more as intended. Closes longturn#782.
lmoureaux
force-pushed
the
bugfix/infinite-loop
branch
from
d37ff64
to
7aa4d96
Compare
|
Rebased for clang-format CI fix, no other change |
|
This is what I see with this patch. |
|
I'm still getting >100% CPU usage as well
|
|
I can reproduce 100% CPU when a unit is selected. Going to fix this too. |
I got a double free in sidebar.cpp:346, which is a protected FREE(final_pixmap). Reset final_pixmap to zero every time it is deleted to avoid this situation.
lmoureaux
added a commit
to lmoureaux/freeciv21
that referenced
this pull request
Dec 31, 2021
The time until next frame was repeatedly divided by 1000, resulting in 0 wait at the end. See longturn#782. See longturn#789.
|
Fixed another source of high CPU usage |
The time until next frame was repeatedly divided by 1000, resulting in 0 wait at the end. See longturn#782. See longturn#789.
lmoureaux
force-pushed
the
bugfix/infinite-loop
branch
from
66fe1a6
to
ab200db
Compare
jwrober
approved these changes
Dec 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resulted from misuse of the Qt APIs. Use them more as intended.
Closes #782.
Test plan: