Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do more error checking in AutoRevision.cmake #876

Merged
merged 2 commits into from
Feb 6, 2022
Merged

Do more error checking in AutoRevision.cmake #876

merged 2 commits into from
Feb 6, 2022

Conversation

lmoureaux
Copy link
Contributor

Every git command can fail, we need to take this into account.

Closes #875.

@lmoureaux
Do more error checking in AutoRevision.cmake
9acfbc9 
Every git command can fail, we need to take this into account.

Closes longturn#875.
@lmoureaux
Copy link
Contributor Author

Not working on Windows, @jwrober do you have an idea? https://github.com/lmoureaux/freeciv21/actions/runs/1803063440

@jwrober
Copy link
Collaborator

jwrober commented Feb 6, 2022

So its working here, but not in your fork? Do you have any tags in your fork?

@jwrober
Copy link
Collaborator

jwrober commented Feb 6, 2022

It also looks like the VERSION variable has some extra lf and chars in it

CMake Error at CMakeLists.txt:47 (project):
  VERSION "

  3.0.813141" format invalid.

@lmoureaux
Strip whitespace out of FC21_REV_TAG harder
d4ec25f 
Also merge the tag name mangling in one single place.
@lmoureaux lmoureaux merged commit 99ff09f into longturn:master Feb 6, 2022
@lmoureaux lmoureaux deleted the bugfix/autorevision branch February 6, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwrober jwrober Awaiting requested review from jwrober

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI builds always "fail"
2 participants
@lmoureaux @jwrober