Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally write fc_version.h and fc_version #885

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

jwrober
Copy link
Collaborator

@jwrober jwrober commented Feb 8, 2022

Closes #879

@lmoureaux
Copy link
Contributor

So it will only update on a new checkout... is it the intended behavior?

@jwrober
Copy link
Collaborator Author

jwrober commented Feb 8, 2022

So it will only update on a new checkout... is it the intended behavior?

So it will work from a new created build directory and it will work with code changes post build to only rebuild those files that need updating based on the changes. It won't work if you run a subsequent configure in an existing build directory. I don't see that as much of an issue per se. I think typical workflow is to delete the build directory after a fresh pull or checkout so it works in that scenario too. All that said, I do think it will have the intended effect.

@lmoureaux
Copy link
Contributor

I tend to never delete my build directories, so in a year from now I might still be using the same version...

@jwrober
Copy link
Collaborator Author

jwrober commented Feb 9, 2022

I tend to never delete my build directories, so in a year from now I might still be using the same version...

Interesting. I'm surprised you don't run into configuration issues with all the changes we have made. Do you want to handle this with a different approach?

@lmoureaux
Copy link
Contributor

I think merging this would be good to get rid of #879. Eventually we may want to:

  1. Move the values to a .cpp file
  2. Generate a temporary file, compare it with the existing one and replace only if they're different

@lmoureaux lmoureaux merged commit dc6c868 into longturn:master Feb 10, 2022
@jwrober jwrober deleted the bugfix/autorev-rebuild branch April 1, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autorevision triggers a full rebuild after every cmake run
2 participants