Try once again to fix stdin handling on Windows #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, there is apparently no unified non-blocking API to wait for input on stdin. Thus, call the blocking API from a worker thread. Tested the following use cases: * Starting from the Windows console * Starting from Windows Explorer (should be the same, but who knows) * Starting from the client (I guess stdin is a named pipe in this case) * Starting from the MSYS console (no idea what it uses, maybe a file) The thread is only used on Windows, no reason for the extra overhead to propagate to sane OSes. Closes longturn#850.
lmoureaux
force-pushed
the
bugfix/windows-stdin-again
branch
from
e28bd2d
to
bcfa146
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, there is apparently no unified non-blocking API to wait for
input on stdin. Thus, call the blocking API from a worker thread.
Tested the following use cases (before rebasing):
The thread is only used on Windows, no reason for the extra overhead to
propagate to sane OSes.
Closes #850.
This should also be tested on Linux even though I don't expect differences there.