Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer support added #28

Closed
wants to merge 13 commits into from
Closed

Composer support added #28

wants to merge 13 commits into from

Conversation

drIceman
Copy link

@drIceman drIceman commented Sep 6, 2019

No description provided.

@rez1dent3
Copy link

@longxinH I think you should not accept this pull request. Too much will have to be pulled through composer.

@drIceman
Copy link
Author

drIceman commented Sep 6, 2019

@rez1dent3 If you reject, then you offer.

@rez1dent3
Copy link

@drIceman There is no good idea, but dragging the source in vendor is bad.
It seems to me there is no problem in resolving it locally

@rez1dent3
Copy link

@drIceman Another option is to put php in a separate project so as not to drag the xhprof sources

@drIceman
Copy link
Author

drIceman commented Sep 6, 2019

I want to do like this https://chromabits.com/posts/2016/02/10/laravel-xhprof/

But only for PHP7.

And I don’t want to set up my repository everywhere, in each of microservices, containers and etc.

This requires the vendor to have composer support.

@longxinH
Copy link
Owner

longxinH commented Sep 9, 2019

@drIceman It is not recommended to use composer. When multiple nodes are used, you can use the form of escalation to display through the center service.

Copy link

@andypost andypost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I see only one commit makes sense 7ac2d3f as it adds useful files via composer but tons of rebased commits is hard to follow

"autoload": {
"files": [
"xhprof_lib/utils/xhprof_lib.php",
"xhprof_lib/utils/xhprof_runs.php"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could be useful as require-dev

@longxinH longxinH closed this Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants