fix: remove eval from lib/gzr/commands/plan/failures.rb

looker-open-source · Nov 7, 2023 · b912249 · b912249
1 parent 1a06c3c
commit b912249
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/lib/gzr/commands/plan/failures.rb b/lib/gzr/commands/plan/failures.rb
@@ -67,7 +67,6 @@ def execute(input: $stdin, output: $stdout)
             }
             data = run_inline_query(query)
             fields = query[:fields]
-            expressions = fields.collect { |f| "[:'#{f}']" }
             begin
               say_ok "No plans found in history"
               return nil
@@ -80,8 +79,8 @@ def execute(input: $stdin, output: $stdout)
               next if row[:'scheduled_plan.id'] == prior_plan_id
               prior_plan_id = row[:'scheduled_plan.id']
               next if row[:'scheduled_job.status'] == 'success'
-              expressions.collect do |e|
-                eval "row#{e}"
+              fields.collect do |f|
+                row.fetch(f.to_sym, nil)
               end
             end.compact
             table = TTY::Table.new(table_hash)