Flushing Memtree #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enlight
requested changes
Jul 2, 2019
mutable_tree.go
Outdated
| @@ -16,6 +16,7 @@ type MutableTree struct { | |||
| *ImmutableTree // The current, working tree. | |||
| lastSaved *ImmutableTree // The most recently saved tree. | |||
| orphans map[string]int64 // Nodes removed by changes to working tree. | |||
| memversions map[int64]bool // The previous, saved versions of the tree in mem. | |||
mutable_tree.go
Outdated
| @@ -364,11 +366,44 @@ func (tree *MutableTree) GetVersioned(key []byte, version int64) ( | |||
| return -1, nil | |||
| } | |||
|
|
|||
| var nextTimeClear = false | |||
mutable_tree.go
Outdated
| version := tree.version + 1 | ||
|
|
||
| if flushToDisk == true { |
mutable_tree.go
Outdated
| } | ||
|
|
||
| func (tree *MutableTree) DeleteVersionFull(version int64, memDeleteAlso bool) error { | ||
| if tree.memversions[version] == true { |
mutable_tree.go
Outdated
| func (tree *MutableTree) DeleteVersionFull(version int64, memDeleteAlso bool) error { | ||
| if tree.memversions[version] == true { | ||
| //sometimes you dont want to bother deleting versions in memory | ||
| if memDeleteAlso == false { |
nodedb.go
Outdated
| ndb.mtx.Lock() | ||
| defer ndb.mtx.Unlock() | ||
|
|
||
| if node.hash == nil { | ||
| panic("Expected to find node.hash, but none found.") | ||
| } | ||
| if node.persistedMem == true && flushToDisk == false { |
There was a problem hiding this comment.
-> if node.persistedMem && !flushToDisk
nodedb.go
Outdated
|
|
||
| node.persisted = true | ||
| ndb.cacheNode(node) | ||
| if flushToDisk == true { |
nodedb.go
Outdated
| if node.persisted { | ||
| return node.hash | ||
| } | ||
| if node.persistedMem && flushToDisk == false { |
There was a problem hiding this comment.
-> if node.persistedMem && !flushToDisk
nodedb.go
Outdated
|
|
||
| node.leftNode = nil | ||
| node.rightNode = nil | ||
| if flushToDisk == true { |
nodedb.go
Outdated
| return ndb.getPreviousVersioni(version, ndb.db) | ||
| } | ||
|
|
||
| func (ndb *nodeDB) getPreviousVersioni(version int64, db dbm.DB) int64 { |
There was a problem hiding this comment.
getPreviousVersioni -> getPreviousVersionFromDB
mattkanwisher
approved these changes
Jul 2, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows using two DBS for storing data.