Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle null animation or controller in _stopHandlerAnimation function #32

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Handle null animation or controller in _stopHandlerAnimation function #32

merged 1 commit into from
Nov 23, 2023

Conversation

john-paradym
Copy link
Contributor

Not sure exactly how you handle pull requests, but this should fix issue #31 that I raised

I didn't see any tests to run, but let me know if there is anything else you need

Thanks
John

@loonix
Copy link
Owner

loonix commented Nov 23, 2023

Looks ok, thanks for your contribution

@loonix loonix merged commit 39c6472 into loonix:master Nov 23, 2023
@loonix loonix self-requested a review November 23, 2023 14:07
@loonix loonix self-assigned this Nov 23, 2023
@loonix loonix added the bug Something isn't working label Nov 23, 2023
@loonix loonix linked an issue Nov 23, 2023 that may be closed by this pull request
_stopHandlerAnimation should stop force unwrapping potentially null parameters #31
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loonix loonix Awaiting requested review from loonix

Assignees

@loonix loonix

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_stopHandlerAnimation should stop force unwrapping potentially null parameters
2 participants
@john-paradym @loonix