Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: TypeScript Build Bugs #115

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Fix: TypeScript Build Bugs #115

merged 2 commits into from
Oct 9, 2023

Conversation

ShivanshVij
Copy link
Member

@ShivanshVij ShivanshVij commented Oct 7, 2023

This PR fixes various TypeScript build bugs, as well as a few Rust and Golang build bugs:

  1. Environment Variables set during the scale function build command now get passed properly to the downstream commands
  2. The build system now allows for wasi and wasm targets depending on the user's choice
  3. The Rust build step now properly verifies the build target with Cargo
  4. Using init function for Rust plugins now properly builds and does not cause builds to break
  5. The TypeScript manifest generator for builds and signatures now returns a pretty-printed package.json
  6. The signature builder now returns the tar.gz format for TypeScript signatures as well as the raw files
  7. The storage manager now properly generates TypeScript signatures for both the guest and the host
  8. Dependencies have been updated

Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
Copy link
Contributor

@jimmyaxod jimmyaxod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShivanshVij ShivanshVij merged commit 2b5dc02 into staging Oct 9, 2023
5 checks passed
@ShivanshVij ShivanshVij deleted the fix-typescript-build branch October 9, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants