Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

James/schema changes #124

Merged
merged 6 commits into from
Nov 22, 2023
Merged

James/schema changes #124

merged 6 commits into from
Nov 22, 2023

Conversation

jimmyaxod
Copy link
Contributor

This changes from a single Schema to V1AlphaSchema and V1BetaSchema.

V1BetaSchema contains extension information.

Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
@jimmyaxod jimmyaxod marked this pull request as ready for review November 21, 2023 18:35
@jimmyaxod
Copy link
Contributor Author

This should essentially contain the groundwork refactoring from shiv/refactor-ext

  • New V1BetaSchema which includes extensions
  • Extension schemas
  • Refactoring build / compile to make args cleaner etc.

Copy link
Member

@ShivanshVij ShivanshVij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimmyaxod jimmyaxod merged commit f317ae0 into staging Nov 22, 2023
5 checks passed
@ShivanshVij ShivanshVij deleted the james/schema_changes branch July 3, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants