Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Instances reuse runtime signature #24

Merged
merged 3 commits into from
Dec 12, 2022
Merged

fix: Instances reuse runtime signature #24

merged 3 commits into from
Dec 12, 2022

Conversation

ShivanshVij
Copy link
Member

Currently, the signature being used in the runtime that is passed into runtime.New gets reused across all instances.

This PR fixes that.

jimmyaxod
jimmyaxod approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@jimmyaxod jimmyaxod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Just a minor question.
Will port this to the typescript code

go/instance.go Show resolved Hide resolved
jimmyaxod added a commit that referenced this pull request Dec 8, 2022
@jimmyaxod
Updated to use signatureFactory as PR #24 go
6c34ff9
@ShivanshVij ShivanshVij merged commit 0312471 into staging Dec 12, 2022
@ShivanshVij ShivanshVij deleted the new-signature branch February 15, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmyaxod jimmyaxod jimmyaxod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShivanshVij @jimmyaxod