Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spain validation incorrect #27

Closed
klemenba opened this issue May 31, 2023 · 5 comments
Closed

Spain validation incorrect #27

klemenba opened this issue May 31, 2023 · 5 comments

Comments

@klemenba
Copy link

Steps required to reproduce the problem

  1. $bool = TIN::fromSlug('esX1042189J')->isValid();

Expected Result

TRUE

Actual Result

FALSE
@drupol
Copy link
Contributor

drupol commented May 31, 2023

The issue has been identified... fix is coming.

@klemenba
Copy link
Author

klemenba commented May 31, 2023 •
edited
Loading

No, I tried with some others too... another example esX1143189C

@drupol drupol closed this as completed in 0a0d3a0 May 31, 2023
@drupol
Copy link
Contributor

drupol commented May 31, 2023

The issue has been fixed, thanks for reporting it.

The fix is included in the new version 1.1.1 that has just been published a few seconds ago.

@drupol
Copy link
Contributor

drupol commented Jun 1, 2023

Dear @ambulanca ,

Can you provide some feedback with the new release? Is the fix working for you?

Thanks.

@klemenba
Copy link
Author

klemenba commented Jun 1, 2023

It's working, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drupol @klemenba