Response headers #170
Response headers #170
Conversation
| # Project target. | ||
| target=android-3 | ||
| target=android-10 |
There was a problem hiding this comment.
I suggest these project properties (and ~/.gitignore) should probably not be changed in this pull request.
There was a problem hiding this comment.
Is there a way to remove them from the request? or is this more of a note for anyone potentially merging it in?
There was a problem hiding this comment.
You can change them back to what master has and push another commit. It should automatically be reflected here.
e.g.
git checkout response-headers
git checkout master -- project.properties .gitignore
git commit -m "Revert changes to project.properties and .gitignore"
git push
There was a problem hiding this comment.
Done (but in a slightly less elegant manner)
reverted to how it was in master
reverted to how it was in master
…headers to fix merge conflicts
|
Waiting for this to be merged :) |
|
I'm considering merging this in, @rustybox could you please merge in master? Thanks |
|
Can you dumb that down for me? I'm still pretty new to git and dvcs lingo. |
|
Try this: git remote add upstream git://github.com/loopj/android-async-http.git |
|
@rustybox If I remember correctly there is a merge conflict, I have a branch that includes the merge fix if you want it, https://github.com/krschultz/android-async-http/tree/feature/response-headers |
…tz/android-async-http into response-headers Conflicts: src/com/loopj/android/http/AsyncHttpResponseHandler.java src/com/loopj/android/http/JsonHttpResponseHandler.java
Conflicts: src/com/loopj/android/http/AsyncHttpResponseHandler.java
|
Cheers @krschultz, right i believe that is resolved @loopj. |
|
Thanks guys! |
|
Thank you for the great lib, it really came in amazingly handy on a recent project :) |
|
Sure no problem, thanks for your contribution. |
|
Thanks guys ! 👍 |
|
cheers guys |
Cleanup of old pull request #160.
Added response headers to onSuccess (in a backwards compatible fashion) for those that need them.