Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds mermaid graph output #50

Merged
merged 8 commits into from
Feb 24, 2020
Merged

feat: adds mermaid graph output #50

merged 8 commits into from
Feb 24, 2020

Conversation

mavogel
Copy link
Contributor

@mavogel mavogel commented Feb 24, 2020 •
edited
Loading

  • I added a simple example and tests for the mermaid output.
  • The old method is still kept and a new factory method is added
  • States and Transitions are now sorted for testability. Does not change the plotted diagram
  • Technical dept: ReplaceAll should be used when the repo is updated to go1.13 -> chore: bumps to go1.13 #51

@mavogel mavogel marked this pull request as ready for review February 24, 2020 10:10
@maxekman
Copy link
Member

Looks good, can be merged after the ReplaceAll is changed.

@mavogel
Copy link
Contributor Author

mavogel commented Feb 24, 2020

Ping @maxekman. Updated to use ReplaceAll

@maxekman maxekman merged commit 9ea0a8d into looplab:master Feb 24, 2020
@mavogel mavogel deleted the feat-mermaid-graph branch February 24, 2020 12:40
@mavogel mavogel mentioned this pull request Feb 24, 2020
Merged
harsh-px pushed a commit to libopenstorage/fsm that referenced this pull request Mar 31, 2020
@mavogel
feat: adds mermaid graph output (looplab#50)
e4b8b6c 
* chore: ignores .coverprofile

* feat: adds mermaid visualize output

* fix: sorts eKeys to have a reproducible graph output

* fix: uses non current transitions with sort as well

* test: adds third transition to verify sorting

* fix: replaces ReplaceAll with Replace due to go1.11

* fix: uses ReplaceAll in tests instead of Replace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mavogel @maxekman