Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: fix mermaid output. #54

Merged
merged 1 commit into from
May 1, 2020
Merged

utils: fix mermaid output. #54

merged 1 commit into from
May 1, 2020

Conversation

peteut
Copy link
Contributor

@peteut peteut commented Apr 20, 2020

Fixes mermaid-js output according https://mermaid-js.github.io/mermaid/#/stateDiagram.

go.mod Outdated
@@ -1,3 +1,3 @@
module github.com/looplab/fsm
module github.com/peteut/fsm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftovers?

Copy link
Contributor Author

@peteut peteut Apr 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, sorry about that. Forgot to do a branch. Should be fixed now.

@maxekman
Copy link
Member

Does this change keep backward compatibility?

@peteut
Copy link
Contributor Author

peteut commented Apr 21, 2020

change keep backward compatibility?

I'm new to mermaid-js and have to check the changelog regarding syntax changes.

@mavogel
Copy link
Contributor

mavogel commented Apr 21, 2020

Thanks @peteut I just figured out I accidentally used flowchart (https://mermaid-js.github.io/mermaid/#/flowchart) instead of statediagram. I guess the first line graph TD confused me 🤔

change keep backward compatibility?

It should be fine because we use another (and now right) chart type

@peteut
Copy link
Contributor Author

peteut commented Apr 22, 2020

I did run into a syntax error with the graph TD solution when using underlines within identifiers (events or states).

@maxekman
Copy link
Member

Tell me when you feel that this is ready to be merged. I don't currently have the possibility to try this out.

@mavogel
Copy link
Contributor

mavogel commented May 1, 2020

@peteut is this ready to be merged tho?

@peteut
Copy link
Contributor Author

peteut commented May 1, 2020

@peteut is this ready to be merged tho?

Yes, it is.

@maxekman maxekman merged commit 8c66c11 into looplab:master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants