Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flowChart style to mermaid visualization #56

Merged
merged 2 commits into from
May 14, 2020

Conversation

julianrschmidt
Copy link

We needed a new way of displaying the state machine in mermaid style in order to highlight the current state. To my knowledge this cannot be easily done with the previously implemented StateDiagram type, which is why we implemented the far more flexible style FlowChart (LR).
The code is backward-compatible .
I would suggest to move the different visualizers (graphviz/mermaid (maybe more in the future)) into separate files, but did not want to do this before general acceptance of this feature.

@maxekman
Copy link
Member

I would be fine with a restructure as it’s not part of the core package. Feel free to do it if you want and can spare the time!

@julianrschmidt
Copy link
Author

@maxekman For now I would leave it like this and propose to merge it into the main project.
In a different merge request, I would like to restructure the visualizer files into a different package. This would require the fsm to publicly export a GetTransitions method, which also might be useful for others to write their own visualizers without having to do this in the fsm package. What do you think?

@maxekman
Copy link
Member

Sounds good!

Copy link
Member

@maxekman maxekman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution. 👍🏼

@julianrschmidt
Copy link
Author

Thank you! Feel free to merge it. We are waiting to use it!

@maxekman maxekman merged commit 54c5586 into looplab:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants