Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linter and fix simple linter warnings #85

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Add linter and fix simple linter warnings #85

merged 1 commit into from
Jul 6, 2022

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented Jul 6, 2022 •
edited
Loading

With this PR i did the following:

  • Added a lint target to the Makefile to ensure further development will not introduce more mistakes.
  • fixed all linter warnings which are generated by the default settings of golangci-lint

@majst01 majst01 mentioned this pull request Jul 6, 2022
Merged
@maxekman
Copy link
Member

maxekman commented Jul 6, 2022

Really nice addition!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 93.655% when pulling 99298c9 on majst01:linter into 72af45e on looplab:main.

@maxekman maxekman merged commit 0b86adf into looplab:main Jul 6, 2022
@majst01
Copy link
Contributor Author

majst01 commented Jul 6, 2022

Thanks Max

@majst01 majst01 deleted the linter branch July 6, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxekman maxekman maxekman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@majst01 @maxekman @coveralls