pkgset: breaking, make default behavior :root #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change: * removes :root, this is the default behavior * removes :noroot, and replaces it with :deps * adds :all, to get the previous behavior When using the expression syntax, the first usage is often to target all the roots and the dependenices... however most reduction need to use :root. Effectively making the expressions longer than they need to be. For a comparison: X - golang.org/x/tools/...:root - github.com/xyz/...:root After this change: X:all - golang.org/x/tools/... - github.com/xyz/... Arguably, the second one is easier to read and understand.
rogpeppe
reviewed
Mar 24, 2021
|
Yeah, but somehow |
|
come to that how about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change:
When using the expression syntax, the first usage is often to target
all the roots and the dependenices... however most reduction need to use
:root. Effectively making the expressions longer than they need to be.
For a comparison:
X - golang.org/x/tools/...:root - github.com/xyz/...:root
After this change:
X:all - golang.org/x/tools/... - github.com/xyz/...
Arguably, the second one is easier to read and understand.
CC @rogpeppe