Add the gradual_shift_duration option to shaders while blocking execution #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumeboehm
force-pushed
the
feature-gradual-shift-blocking
branch
from
b27de7b
to
7bcc78a
Compare
|
With the recent changes I ended up using the [shaders.config] for the shader to fetch the gradual_shift_duration. But it feels somewhat hacky I think, because it's not a variable that is directly passed to the shader... But I suppose you didn't want the shader to have the whole config for no reason? |
guillaumeboehm
force-pushed
the
feature-gradual-shift-blocking
branch
from
7bcc78a
to
cd97ef4
Compare
|
Implemented it with an normal config and not a shader variable, it does feel hacky though... Not having the full config in the shader ends up making it a bit annoying. |
guillaumeboehm
force-pushed
the
feature-gradual-shift-blocking
branch
4 times, most recently
from
fcc9177
to
316a378
Compare
guillaumeboehm
force-pushed
the
feature-gradual-shift-blocking
branch
from
316a378
to
e5a4a1d
Compare
This commit adds the `gradual_shift_duration` option to shaders in hyprshade.toml. Any shader with a `start_time` can have this option. With the option set, `hyprshade on` will block execution for the time set in `gradual_shift_duration` and gradually set the shader while increasing the `gradualPercentage` glsl variable. If the concerned shader is not a template or does not implement the `gradualPercentage` variable, `gradual_shift_duration` will have no effect. The `blue-light-filter` shader is now a mustache template and the `gradualPercentage` variable is implemented for it. The option was also added to the `test_config`
options commit to fixup if approved
guillaumeboehm
force-pushed
the
feature-gradual-shift-blocking
branch
from
e5a4a1d
to
964d57f
Compare
|
excited for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same feature as #29, different implementation.
This PR adds the gradual_shift_duration option to shaders in hyprshade.toml.
With the option set,
hyprshade onwill block execution for the time set ingradual_shift_durationand gradually set the shader while increasing thegradualPercentageglsl variable.If the concerned shader is not a template or does not implement the
gradualPercentagevariable,gradual_shift_durationwill have no effect.