Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PvP: Refactoring: extract controls mod #1550

Closed
Tracked by #1518
alek13 opened this issue Jul 17, 2024 · 3 comments
Closed
Tracked by #1518

PvP: Refactoring: extract controls mod #1550

alek13 opened this issue Jul 17, 2024 · 3 comments
Assignees
@alek13
Labels
external Связанное с внешним окружением

Comments

@alek13
Copy link
Member

alek13 commented Jul 17, 2024 •
edited
Loading

https://content.minetest.net/packages/mt-mods/controls/

EDIT:
after research:
наш немного лучше, ждать PR нет смысла -- мод маленький переподключить всегда можно.
оставляем наш, но выносим в отдельный мод
@alek13 alek13 mentioned this issue Jul 17, 2024
Open
@alek13 alek13 added the external Связанное с внешним окружением label Jul 17, 2024
alek13 added a commit to alek13/lord that referenced this issue Jul 17, 2024
@alek13
Add controls mod as submodule. Relates to lord-server#1550
983fcdf
alek13 added a commit to alek13/lord that referenced this issue Jul 17, 2024
@alek13
Add controls mod as submodule. Relates to lord-server#1550
d59e9ee
alek13 added a commit to alek13/lord that referenced this issue Jul 17, 2024
@alek13
Add controls mod as submodule. Relates to lord-server#1550
9f2f39b
@Doloment
Copy link
Contributor

В controls отсутствуют необходимые для луков функции, реализованные в нашем варианте:
registered_on_wield_index_change
register_on_wield_index_change

@alek13
Copy link
Member Author

alek13 commented Jul 17, 2024

ага, спасибо, учту

@alek13
Copy link
Member Author

alek13 commented Jul 17, 2024

upd desc

@alek13 alek13 changed the title PvP: Lord Bows: move to controls mod PvP: Lord Bows: extract controls mod Jul 17, 2024
@alek13 alek13 self-assigned this Jul 17, 2024
alek13 added a commit to alek13/lord that referenced this issue Jul 17, 2024
@alek13
Refactoring: extract controls mod from lordlib. Closes lord-serve…
882da3e 
…r#1550.
@alek13 alek13 closed this as completed in 9a95c02 Jul 17, 2024
@alek13 alek13 changed the title PvP: Lord Bows: extract controls mod PvP: Refactoring: extract controls mod Jul 17, 2024
@alek13 alek13 mentioned this issue Jul 8, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alek13 alek13

Labels
external Связанное с внешним окружением
Projects
PvP
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alek13 @Doloment