Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: Extract minimal BaseForm class #1565

Closed
11 tasks done
alek13 opened this issue Jul 20, 2024 · 0 comments
Closed
11 tasks done

Refactoring: Extract minimal BaseForm class #1565

alek13 opened this issue Jul 20, 2024 · 0 comments
Assignees
@alek13
Labels
lord Связанное с модами lord refactoring Касающееся крупной переработки имеющейся возможности

Comments

@alek13
Copy link
Member

alek13 commented Jul 20, 2024 •
edited
Loading

Generally it would be something like:

  • BaseForm
  • Form Factory with something like:
    • ala mixins methods:
      • [ ] shared()
      • persona()
      • for_node()
      • with_tabs()
    • extend() - class creation method
  • sub-classes for each minxin

Replace for forms:

  • reward chest form
  • trader form
  • clans chest
@alek13 alek13 changed the title Refactoring: Extract minimal Form class Refactoring: Extract minimal BaseForm class Jul 20, 2024
@alek13 alek13 self-assigned this Jul 21, 2024
@alek13 alek13 added refactoring Касающееся крупной переработки имеющейся возможности lord Связанное с модами lord labels Jul 21, 2024
alek13 added a commit to alek13/lord that referenced this issue Jul 24, 2024
@alek13
base_classes: improve Event: ability to link generated by :on()…
f7fd210 
… to another object. Needs for lord-server#1565
alek13 added a commit to alek13/lord that referenced this issue Jul 24, 2024
@alek13
Refactoring: base_classes: add BaseForm first version (no mixins)…
0e4cd79 
…. Relates to lord-server#1565
alek13 added a commit to alek13/lord that referenced this issue Jul 25, 2024
@alek13
base_classes: add mixin system for Form. Relates to lord-server#1565
2473017
alek13 added a commit to alek13/lord that referenced this issue Jul 25, 2024
@alek13
base_classes: add ForNode & WithTabs minxins for Forms. Relat…
c0eb275 
…es to lord-server#1565
alek13 added a commit to alek13/lord that referenced this issue Jul 25, 2024
@alek13
base_classes: add Personal form mixin (extract from Form.Base. …
2923941 
…Relates to lord-server#1565
alek13 added a commit to alek13/lord that referenced this issue Jul 25, 2024
@alek13
base_classes: add Personal form mixin (extract from Form.Base. …
9efe220 
…Relates to lord-server#1565
alek13 added a commit to alek13/lord that referenced this issue Jul 25, 2024
@alek13
base_classes: clean doc-blocks for forms classes; move fogotten `on…
62221cf 
…_close` to `Personal. Relates to lord-server#1565
alek13 added a commit to alek13/lord that referenced this issue Jul 25, 2024
@alek13
Refactoring: base_classes: Form: use new forms for `quest_node:re…
8a41ba5 
…ward_chest`. Relates to lord-server#1565
alek13 added a commit to alek13/lord that referenced this issue Jul 25, 2024
@alek13
Refactoring: base_classes: Form: use new forms for `clan_node:che…
af8465c 
…st`. Relates to lord-server#1565
alek13 added a commit to alek13/lord that referenced this issue Jul 26, 2024
@alek13
base_classes: Event: improve :extended(), clean doc-blocks. Rel…
d043ccf 
…ates to lord-server#1558, lord-server#1565
alek13 added a commit to alek13/lord that referenced this issue Jul 26, 2024
@alek13
base_classes: Form: improve Form.Event:extended(); fix form eve…
6c6a422 
…nts subscriptions. Relates to lord-server#1565
alek13 added a commit to alek13/lord that referenced this issue Jul 26, 2024
@alek13
Refactoring: base_classes: Form: use new forms for lord_traders…
d04e1e7 
…. Relates to lord-server#1565
@alek13 alek13 closed this as completed Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alek13 alek13

Labels
lord Связанное с модами lord refactoring Касающееся крупной переработки имеющейся возможности
Projects
Рефакторинг
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alek13