Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: lottarmor #339

Closed
10 tasks done
vladtcvs opened this issue May 11, 2021 · 2 comments
Closed
10 tasks done

Refactoring: lottarmor #339

vladtcvs opened this issue May 11, 2021 · 2 comments
Assignees
@alek13
Labels
idea Предложенная идея, или запрос на добавление новой возможности issues group Для задач: несколько задач в одной refactoring Касающееся крупной переработки имеющейся возможности

Comments

@vladtcvs
Copy link
Contributor

vladtcvs commented May 11, 2021 •
edited by alek13
Loading

Проблема:

Код, отвечающий за броню, одежду, скины - ужасен и нечитаем.
Одежда сломана. испр. в #390

Предложение:

Привести его в порядок.

@alek13 :
@vladtcvs vladtcvs added the idea Предложенная идея, или запрос на добавление новой возможности label May 11, 2021
@vladtcvs vladtcvs mentioned this issue May 11, 2021
Merged
@alek13
Copy link
Member

alek13 commented May 11, 2021

Нужно обсудить на созвоне. Включу в повестку. Анонс созвона будет в Discord

@alek13 alek13 added this to the next-milestone milestone Aug 22, 2021
@vladtcvs
Copy link
Contributor Author

Одежда исправлена: #390

@alek13 alek13 modified the milestones: 2021.09, next-milestone Sep 1, 2021
@vladtcvs vladtcvs mentioned this issue Mar 16, 2022
Closed
@ssdaniel24 ssdaniel24 changed the title Привести в порядок скины + броню + одежду Переработка lottarmor Aug 26, 2022
@ssdaniel24 ssdaniel24 added the refactoring Касающееся крупной переработки имеющейся возможности label Aug 26, 2022
@alek13 alek13 changed the title Переработка lottarmor Refactoring: lottarmor Jan 18, 2023
alek13 added a commit that referenced this issue Jan 29, 2023
@alek13
Remove unused support of player_textures mod. Relates to #339
64baa3d
@alek13 alek13 mentioned this issue Jan 30, 2023
Closed
alek13 added a commit that referenced this issue Jan 30, 2023
@alek13
lottarmor: remove ethereal & moreores support. Closes #972. Rel…
c455cdd 
…ates to #339.
alek13 added a commit that referenced this issue Jan 30, 2023
@alek13
lottarmor: remove configs support. Closes #973. Relates to #339.
4480230
alek13 added a commit that referenced this issue Jan 30, 2023
@alek13
lottarmor: remove unused vars. Closes #974. Relates to #339.
6aae915
alek13 added a commit to alek13/lord that referenced this issue Jan 30, 2023
@alek13
Use default form styles. Relates to lord-server#339
ad61ccd
alek13 added a commit to alek13/lord that referenced this issue Feb 1, 2023
@alek13
Separate bags form from armor. Relates to lord-server#976 lord-server…
4cf9e2d 
…#339
@alek13 alek13 self-assigned this Apr 12, 2023
alek13 added a commit to alek13/lord that referenced this issue Apr 14, 2023
@alek13
lottarmor: move inventory forms into Player/lord_inventory. Relat…
2fc0535 
…es to lord-server#339. Closes lord-server#354.
alek13 added a commit to alek13/lord that referenced this issue Apr 14, 2023
@alek13
lottarmor: move inventory forms into Player/lord_inventory. Relat…
ac04eaf 
…es to lord-server#339. Closes lord-server#354.
alek13 added a commit that referenced this issue Apr 14, 2023
@alek13
lottarmor: move forgotten armor textures. Relates to #971, #339
41f2965
alek13 added a commit that referenced this issue Apr 14, 2023
@alek13
lottarmor: move forgotten inventory textures. Relates to #354, #339.
65d0ca3
@alek13 alek13 added the issues group Для задач: несколько задач в одной label Apr 17, 2023
alek13 added a commit to alek13/lord that referenced this issue Apr 20, 2023
@alek13
lottarmor: remove nonexistent button handler. Relates to lord-serve…
5950bec 
…r#339, lord-server#1011
alek13 added a commit to alek13/lord that referenced this issue Apr 20, 2023
@alek13
lottarmor: move multiskin.lua into Player/appearance. Relates to …
bdca94b 
…lord-server#339, lord-server#1011
alek13 added a commit to alek13/lord that referenced this issue Apr 20, 2023
@alek13
move preview default into appearance. Relates to lord-server#339
4c684ca
alek13 added a commit to alek13/lord that referenced this issue May 5, 2023
@alek13
Refactoring lottarmor: move "shield" value of armor.elements into…
33da08d 
… declaration. Relates to lord-server#339
alek13 added a commit to alek13/lord that referenced this issue May 5, 2023
@alek13
equipment.ForPlayer: add :clear(kind), :items(kind), fix `:get(…
8bcb1e1 
…)`. Closes lord-server#1021. Relates to lord-server#1012, lord-server#1017, lord-server#339
alek13 added a commit to alek13/lord that referenced this issue May 7, 2023
@alek13
equipment.ForPlayer: add :move_to(kind), :items(kind), fix `:ge…
d5a9419 
…t()`. Relates to lord-server#1028, lord-server#1012, lord-server#1017, lord-server#339
alek13 added a commit to alek13/lord that referenced this issue May 7, 2023
@alek13
Decrease armor/clothing/equipment dependencies. Relates to lord-serve…
d91736d 
…r#339, lord-server#1012, lord-server#1017.
alek13 added a commit to alek13/lord that referenced this issue May 26, 2023
@alek13
Refactoring lottarmor: remove unnecessary code. Relates to lord-ser…
300a05e 
…ver#339
alek13 added a commit to alek13/lord that referenced this issue May 26, 2023
@alek13
Refactoring lottarmor: simplify armor:set_player_armor(). Relates…
b8071a6 
… to lord-server#339
alek13 added a commit to alek13/lord that referenced this issue May 26, 2023
@alek13
Refactoring lottarmor: extract collect_physics(). Relates to lord…
ae14023 
…-server#732, lord-server#339, lord-server#1012
alek13 added a commit to alek13/lord that referenced this issue May 26, 2023
@alek13
Refactoring lottarmor: extract rebuild_armor_groups(). Relates to l…
3885455 
…ord-server#732, lord-server#339, lord-server#1012
alek13 added a commit to alek13/lord that referenced this issue May 27, 2023
@alek13
Refactoring lottarmor: simplify handle_armor_wear: extract `item_…
8c8e551 
…wear`. Closes lord-server#732. Relates to lord-server#339, lord-server#1012.
alek13 added a commit to alek13/lord that referenced this issue May 29, 2023
@alek13
fix typo. Relates to lord-server#339
8d6f234
alek13 added a commit to alek13/lord that referenced this issue May 29, 2023
@alek13
Refactoring lottarmor: use equipment.on_load(); remove delay. Rel…
61c915a 
…ates to lord-server#339, lord-server#1012
alek13 added a commit to alek13/lord that referenced this issue Jun 5, 2023
@alek13
Fix nenya ring armor. Fixes lord-server#1054. Relates to lord-server#339
76acdfd
@alek13 alek13 mentioned this issue Sep 13, 2023
Closed
9 tasks
alek13 added a commit to alek13/lord that referenced this issue Jul 27, 2024
@alek13
Refactoring: lottarmor: separate wear handling. Relates to lord-ser…
4ed8bf8 
…ver#339, lord-server#1012. Closes lord-server#977
alek13 added a commit to alek13/lord that referenced this issue Jul 27, 2024
@alek13
Refactoring: lottarmor: move armor wear into equipment_armor. Rel…
86dc25b 
…ates to lord-server#339, lord-server#1012
alek13 added a commit to alek13/lord that referenced this issue Jul 27, 2024
@alek13
Refactoring: lottarmor: move armor wear into equipment_armor. Rel…
4444bfc 
…ates to lord-server#339, lord-server#1012
alek13 added a commit to alek13/lord that referenced this issue Jul 28, 2024
@alek13
Refactoring: lottarmor: remove unused. Relates to lord-server#339, l…
cf6da67 
…ord-server#1012.
alek13 added a commit to alek13/lord that referenced this issue Jul 28, 2024
@alek13
Refactoring: lottarmor: extract get_armor_healing_chance() functi…
0fef3db 
…on. Relates to lord-server#339, lord-server#1012
alek13 added a commit to alek13/lord that referenced this issue Jul 28, 2024
@alek13
Refactoring: lottarmor: no globalstep, use `register_on_punchplayer…
812da0e 
…()` for check healing on hit. Relates to lord-server#339, lord-server#1012.
alek13 added a commit to alek13/lord that referenced this issue Jul 28, 2024
@alek13
Refactoring: lottarmor: no globalstep, use `register_on_punchplayer…
a39361f 
…()` for check healing on hit. Relates to lord-server#339, lord-server#1012.
alek13 added a commit to alek13/lord that referenced this issue Jul 28, 2024
@alek13
Refactoring: lottarmor: extract healing into separate file. Relates…
5cc6586 
… to lord-server#339, lord-server#1012.
alek13 added a commit to alek13/lord that referenced this issue Jul 28, 2024
@alek13
Refactoring: lottarmor: mini restruct function. Relates to lord-ser…
2839feb 
…ver#339, lord-server#1012.
alek13 added a commit to alek13/lord that referenced this issue Jul 28, 2024
@alek13
Refactoring: lottarmor: fix healing (damage avoid). Relates to lord…
620c934 
…-server#339, lord-server#1012.
alek13 added a commit to alek13/lord that referenced this issue Jul 28, 2024
@alek13
Refactoring: lottarmor: rename "armor-heal" to "armor-damage-avoid"…
d4652ce 
…. Now it works! Relates to lord-server#339, lord-server#1012.
alek13 added a commit to alek13/lord that referenced this issue Jul 28, 2024
@alek13
Refactoring: lottarmor: remove now unused armor.player_hp. Relate…
4d8b3bb 
…s to lord-server#339, lord-server#1012.
alek13 added a commit to alek13/lord that referenced this issue Jul 28, 2024
@alek13
Refactoring: lottarmor: no negative damage. Now player not pulls by…
b7b48b7 
… hit. Relates to lord-server#339, lord-server#1012.
alek13 added a commit to alek13/lord that referenced this issue Jul 29, 2024
@alek13
Refactoring: lottarmor: no negative damage. Now player not pulls by…
72e41ad 
… hit. Relates to lord-server#339, lord-server#1012. Fixes lord-server#1289.
@alek13 alek13 closed this as completed in cea74ea Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alek13 alek13

Labels
idea Предложенная идея, или запрос на добавление новой возможности issues group Для задач: несколько задач в одной refactoring Касающееся крупной переработки имеющейся возможности
Projects
Рефакторинг
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alek13 @vladtcvs @ssdaniel24