Invalid proofs #15
Merged
Invalid proofs #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also added some manual tests (see #11) |
lorenzb
force-pushed
the
invalid_proofs
branch
2 times, most recently
from
bc97cb3
to
f65ec95
Compare
lorenzb
force-pushed
the
invalid_proofs
branch
from
ba25678
to
54a38ff
Compare
lorenzb
force-pushed
the
invalid_proofs
branch
from
54a38ff
to
6ae6b50
Compare
relyt29
reviewed
Sep 27, 2018
| @@ -190,26 +186,19 @@ contract ProvethVerifier { | |||
| bytes32 blockHash, | |||
| bytes proofBlob | |||
| ) internal returns (uint8 result, uint256 index, Transaction memory t) { | |||
| result = TX_PROOF_RESULT_INVALID; | |||
There was a problem hiding this comment.
Not sure why you're getting rid of this? I generally favor descriptive names to returning an integer, but it's probably fine either way
There was a problem hiding this comment.
I got rid of TX_PROOF_RESULT_INVALID, since we now revert on invalid proofs.
But I could probably kick out
result = 0;
index = 0;
since that's the default anyways.
|
Okay, reviewed code and ran tests everything seems good to me to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests depends on #14
It currently implements the first part of #9, i.e. reverting on invalid proofs.