Removed connection profile URL validation #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When executing charging station test case TC_B_43_CS detailed in part 6 of the standard, the charging station is supplied with an invalid URL and should respond with a rejected request not an error.
lorenzodonini
approved these changes
Oct 22, 2023
|
Fair enough, thanks for submitting this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing charging station test case TC_B_43_CS detailed in part 6 of the standard, the charging station is supplied with an invalid URL by the OCTT (OCA's testing tool) and should respond with a rejected SetNetworkProfileResponse, not an error.
To this end, I removed the URL validation and associated test for the connection profile struct, the user will have to do the URL validation themselves and then respond with 'Rejected' accordingly.