Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed removal of all colors and issue of canvas size limitation #113

Closed
wants to merge 5 commits into from
Closed

Fixed removal of all colors and issue of canvas size limitation #113

wants to merge 5 commits into from

Conversation

itsamrit
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Dec 30, 2022

Deploy Preview for competent-tesla-4b5f1e ready!

Name Link
🔨 Latest commit ef1166b
🔍 Latest deploy log https://app.netlify.com/sites/competent-tesla-4b5f1e/deploys/63b02228ca3db40008c9eb7d
😎 Deploy Preview https://deploy-preview-113--competent-tesla-4b5f1e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@itsamrit itsamrit changed the title Fixed removal of all colors issue. Fixed removal of all colors and issue of canvas size limitation Dec 30, 2022
@unsettledgames
Copy link
Collaborator

Hello, thanks for posting, a few things:

  • When trying to remove all the colours, instead of alerting the user, the app should probably just remove all the colours but the last one
  • The checks in the canvas size aren't really enough at the moment. The canvas size should probably have an upper limit as well (something like 5000 pixels would probably be ok) and it shouldn't let users write alphabetical characters in the input fields. In addition, the checks should be performed on every dialog that requires a canvas size as an input

What I was thinking regarding the previous point (#85 so that it gets referenced there) was having a static function (or its corresponding version in JS) that validates an input field (for example the width or the height of a canvas), given the accepted range and the type of input. The editor shouldn't let users type incorrect values at all, so this validation function would have to be called when the onupdate event of a field is triggered.

Let me know if you want to address this feedback. Otherwise you can just fix the palette removal bug, change the name of this PR and call it a day.

@itsamrit
Copy link
Contributor Author

Hi, thanks for the feedback. Currently, I am just going to fix the palette removal bug and in coming days I will also fix the canvas size issue as per your feedback.

@itsamrit itsamrit closed this Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants