This repository has been archived by the owner on Sep 4, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Search on word/name, if partially found in resource it will return the resource
Deploy preview for upbeat-albattani-cbe0ee ready! Built with commit b96b04f https://deploy-preview-194--upbeat-albattani-cbe0ee.netlify.com |
refactor state.tags & state.resources
S3B4S
changed the title
[WIP] Add search functionality
[WIP] Add search functionality & tests
Oct 22, 2019
- add test for getting all tags - add test for transforming resources - output.json -> mockOutput.json
Closed
Merged
S3B4S
changed the title
[WIP] Add search functionality & tests
Add search functionality & tests
Nov 9, 2019
lostdesign
suggested changes
Nov 12, 2019
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can search on tags or words.
Tags
#ux
will return all the resources that have the#ux
tag.#ux #educational
will return all the resources that have the#ux
OR the#educational
tag.There is no autocomplete or partially matching for tags (eg.
#u
won't match#ux
).Words
user
will return all the resources that include the stringuser
in either the url, cleanTitle or description.user a11y
works in an OR fashion aswell.Combined
Same goes for searching for both tags and words;
#ux user
will return the resources as described above in OR fashion.This behaviour is not set in stone, I just wanted to start somewhere. If there are libraries and/or suggestions for other behaviour expected from searching I'd like to hear it. This is by no means anything final yet.
Tests
Figured while I'm at it I'll also add tests
https://medium.com/@gogl.alex/nuxt-jest-setup-from-scratch-8905d3880daa