-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts #223
Scripts #223
Conversation
FileUtils.mkdir_p File.expand_path("../../pkg", __FILE__) | ||
puts `script/gemspec` | ||
puts `gem build #{MakeScript.gemspec_file}` | ||
puts `mv #{MakeScript.gem_file} pkg` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use system
for these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...it would mean you wouldn't need to use puts
or the backticks, and would mean it would print the output as it did the work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right. For some reason I thought that was rake only, but I may be thinking of #sh
.
This is pretty sweet. I would love to see a version of rakegem that used this convention. I guess we would need to name it something else, eh? |
That's why ruby.rb defines MakeScript :) Trying to come up with something like "RakeGem" but more language agnostic. 🤷 |
I feel like |
I like package. I think faraday is the first library that's tried this convention, so we don't have one for this afaik. |
Closing, cherry picked these into master. |
👍 I like A bunch of these could easily be POSIX shell instead of Ruby, but I assume you're Rubying on purpose. :) |
I did them in ruby just to get a clean transition from rakegem. @mislav On Fri, Dec 28, 2012 at 10:45 AM, John Barnette notifications@github.comwrote:
Rick Olson |
Extract the rakegem rakefile to individual scripts. This removes a dependency (Rake), and gives the project a definitive place for various administrative actions:
This approach borrows heavily from mojombo/rakegem, but favors scripts over Rake. I prefer this to using Rake + Bundler, because the tasks are simple and visible. Being visible makes it easy to tweak them later as needs change. Having a full manifest in the gemspec lets us easily diff gemspec changes between versions.
This is also striving to conform to some internal GitHub script conventions. You can run
script/test
without caring what language or programming environment you're in./cc @sferik @jbarnette