204, 304 must not have a body #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you accidentally checked in |
| <w>upcaser</w> | ||
| </words> | ||
| </dictionary> | ||
| </component> No newline at end of file |
There was a problem hiding this comment.
Did you intend to add this file?
|
Looks good to me. |
|
sorry guys on the idea xml file...i'm new to this and this was an accident. i removed it from my steveburkett fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I just made a fix to faraday to not process a 204/304 body in response.rb and 2 tests.
please see http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html (under 204/304 codes)
Hope all is well and this is helpful to faraday :)