Fix #33 - Propagate non-default on_body receivers through redirects #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 12, 2015
| end | ||
|
|
||
| assert_equal "ok", body.join | ||
| end |
Open
kkirsche
added a commit
that referenced
this pull request
Oct 31, 2015
Fix #33 - Propagate non-default on_body receivers through redirects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copies any on_body receivers through automatic redirects. Generally we only want the last body received. In the default case, the BodyReceiver will just get reset each time which is fine. For custom receivers, redirect response bodies can be ignored by filtering on status (e.g. only 200, 201..)
Needs #28 to me merged to work outside tests.