Pass --cmd-history instead of --history for interactive commands in vim #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Noticed that history navigation for interactive
rginvocations via skim had either stopped working or not worked at all.Found that it just wasn't putting anything in the history file, even though
g:skim_history_dirwas set, and followed it back to this.This patch makes the vim plugin check if the
-iflag is passed, and if so passes the history file as--cmd-historyinstead of--history. This seems to resolve the issue without breaking history for e.g.Buffers.Have a good one! :)