Introduce feature sendIntermediates (define, document, test) #1
Conversation
…y targets without deleting definitions
…st and fix more typos in comments and whitespaces
…non-exiting calls and a die() with better error context
…on that is expected to work vs. complicated setup that is not (so far)
…g tank/source/dest-disabled, it confuses other code at the moment
…efined in dataSets array
…or snapshots defined in dataSets array
|
On Fri, Nov 22 2019 08:28:06 +0000, Jim Klimov wrote:
Follow-up to discussion at oetiker#455
CC @lotheac @oetiker
You can view, comment on, or merge this pull request online at:
looks good to me, but not sure why you made it a PR to my fork, not
oetiker's :)
…
#1
-- Commit Summary --
* Introduce feature sendIntermediates (define, document, test)
-- File Changes --
M bin/znapzend (26)
M doc/znapzend.pod (24)
M lib/ZnapZend.pm (3)
M lib/ZnapZend/ZFS.pm (4)
M man/znapzend.1 (23)
M t/znapzend.t (2)
-- Patch Links --
https://github.com/lotheac/znapzend/pull/1.patch
https://github.com/lotheac/znapzend/pull/1.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#1
--
Lauri Tirkkonen | lotheac @ IRCnet
|
|
To inherit your commit, and eventually if you merge - the linked discussion at your original PR for the feature :) |
…ult (and only) activity forever before
|
I like this, but the default should not change .. so maybe better have |
Allow to set dst_N_enabled=off to comment away targets without deleting definitions
|
No problem with this on my side (even better so, per least-surprise principle). But Lauri may get upset :) |
…nal default in place (maybe safer on side of caution, and least-surprise for existing deployments and users)
|
So updated the code and docs to revive the upstream's default. Also noted that for regular background |
|
Hm... seems travis is not enabled in this fork :) I'll resubmit as PR to upstream... |
|
On Fri, Nov 22 2019 07:00:37 -0800, Jim Klimov wrote:
No problem with this on my side (even better so, per least-surprise principle). But Lauri may get upset :)
nah, I can configure on my end ofc.
…
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#1 (comment)
--
Lauri Tirkkonen | lotheac @ IRCnet
|
Follow-up to discussion at oetiker#455
CC @lotheac @oetiker