Rack::Lint compatibility #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ders in HEAD request
|
@AlfonsoUceda This fixes the problem, thank you 👍 |
|
Thanks for your work! 👏 It is working without issues now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Both
Rack::Lintand Rack SPEC aren't compliant with RFC 2016 (see rack/rack#787) for entity headers.The RFC allows headers like
Content-TypeandContent-Lengthto be sent when the status code is204, butRack::Lintdon't.Solution
We make Lotus compliant with
Rack::Lintuntil they don't fix this problem.