Skip to content

Added automatically expires option if max_age option presents #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2015
Merged

Added automatically expires option if max_age option presents #110

merged 1 commit into from
May 20, 2015

Conversation

AlfonsoUceda
Copy link
Contributor

Closes #107

Now when you set max_age in a cookie, automatically expires option is set (Time.now + max_age option).

cookies[:foo] = { value: 'bar', max_age: 120 }
"'Set-Cookie' => 'bar=foo; max-age=120; expires=Fri, 15 May 2015 10:49:42 -0000'"

@jodosha jodosha self-assigned this May 20, 2015
@jodosha jodosha added this to the v0.4.3 milestone May 20, 2015
@jodosha jodosha merged commit b353757 into hanami:master May 20, 2015
jodosha added a commit that referenced this pull request May 20, 2015
@jodosha
Cleanup per #110
f61efd5
@jodosha
Copy link
Member

jodosha commented May 20, 2015

@AlfonsoUceda thank you 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jodosha jodosha

Labels

enhancement

Projects

None yet

Milestone

v0.4.3

Development

Successfully merging this pull request may close these issues.

Cookies: automatic "expires" setting

2 participants

@AlfonsoUceda @jodosha