-
-
Notifications
You must be signed in to change notification settings - Fork 114
Fix specs when running on JRuby. #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There is a difference in how JRuby and MRI sort_by algorithm works when sorting elements with the same weight. More info: jruby/jruby#3004 Calling #sort! before #sort_by in JRuby appears to make it work just like MRI does.
@lucasallan thanks for the PR. I could see JRuby 9k build still fail. Does this PR address that issue or different one? |
That failed spec doesn't seem related to my changes. I ran the specs several times in my local environment with JRuby 9k (
|
@JONESLEE85 I added the latest version of jruby |
@lucasallan should we bump our requirement to min |
cc @jodosha @AlfonsoUceda for 1 more 👍 |
Yes, I think so - this is the stable release version of JRuby 9k. |
@lucasallan Thanks, I've merged it! ✨ |
Yay! Great job :) We're almost there 💃 |
There is a difference in how JRuby and MRI sort_by algorithm works when sorting elements with the same weight. More info: jruby/jruby#3004
Calling #sort! before #sort_by in JRuby appears to make it work just like MRI does.