Skip to content

Conversation

lucasallan
Copy link
Contributor

There is a difference in how JRuby and MRI sort_by algorithm works when sorting elements with the same weight. More info: jruby/jruby#3004

Calling #sort! before #sort_by in JRuby appears to make it work just like MRI does.

  There is a difference in how JRuby and MRI sort_by algorithm works when
  sorting elements with the same weight.
    More info: jruby/jruby#3004
  Calling #sort! before #sort_by in JRuby appears to make it work just
  like MRI does.
@runlevel5
Copy link

@lucasallan thanks for the PR. I could see JRuby 9k build still fail. Does this PR address that issue or different one?

@runlevel5 runlevel5 added this to the 0.6.0 milestone Oct 14, 2015
@lucasallan
Copy link
Contributor Author

That failed spec doesn't seem related to my changes. I ran the specs several times in my local environment with JRuby 9k (jruby 9.0.1.0) and it always pass. I also noticed that you're running on JRuby 9.0.0.0.pre1 - this might be the issue.

➜  controller git:(master) ruby -v
jruby 9.0.1.0 (2.2.2) 2015-09-02 583f336 Java HotSpot(TM) 64-Bit Server VM 25.60-b23 on 1.8.0_60-b27 +jit [darwin-x86_64]
➜  controller git:(master) rake test
Run options: --seed 29639

# Running:

.....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................S...............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................S....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

Finished in 6.945280s, 365.4280 runs/s, 832.9398 assertions/s.

2538 runs, 5785 assertions, 0 failures, 0 errors, 2 skips

You have skipped tests. Run with --verbose for details.
➜  controller git:(master) 

@lucasallan
Copy link
Contributor Author

@JONESLEE85 I added the latest version of jruby 9.0.1.0 to the .travis.yml and all the specs are passing.

@runlevel5
Copy link

@lucasallan should we bump our requirement to min 9.0.1.0?

@runlevel5
Copy link

cc @jodosha @AlfonsoUceda for 1 more 👍

@lucasallan
Copy link
Contributor Author

Yes, I think so - this is the stable release version of JRuby 9k.

@jodosha jodosha merged commit 0bb6ba3 into hanami:master Oct 14, 2015
jodosha added a commit that referenced this pull request Oct 14, 2015
@jodosha
Copy link
Member

jodosha commented Oct 14, 2015

@lucasallan Thanks, I've merged it! ✨

@brennovich
Copy link

Yay! Great job :)

We're almost there 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants