Remove Lotus::Controller DSL #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
IMHO, naming ArticlesController express the identity of the controller better, it'd help Rails dev pick up Lotus more easily
There was a problem hiding this comment.
@JONESLEE85 In full stack applications we use this namespace: Bookshelf::Controllers, it would be repetitive to have Bookshelf::Controllers::ArticlesController::Show, that's want to encourage this new naming.
In standalone mode, we should suggest developers to put their controllers under Controllers as well, to avoid name clashes. Eg. Identity (model domain object) and Identity::Index (controller + action).
Does it makes sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #49