Skip to content

Conversation

jodosha
Copy link
Member

@jodosha jodosha commented Dec 8, 2014

Closes #59

@jodosha jodosha self-assigned this Dec 8, 2014
@jodosha jodosha added this to the v0.3.0 milestone Dec 8, 2014
@runlevel5
Copy link

I manually test the sort_by in Ruby 2.1 and 2.2 yet I could not reproduce the bug. I think there is something in the Rack implementation or somewhere might monkey-patch or do something that cause side-effect on sort_by

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 15f7594 on fix-rack-utils-mri-2-2-0 into * on master*.

@jodosha
Copy link
Member Author

jodosha commented Dec 8, 2014

@JONESLEE85 Which OS? Have you tried with the array_sort_by.rb test reported in #59? That's just plain Ruby without gems.

@runlevel5
Copy link

@jodosha I tried it on my OSX.

@jodosha
Copy link
Member Author

jodosha commented Dec 8, 2014

@JONESLEE85 Yeah, it works on OS X 10.9 (my machine), but not on Ubuntu.

@runlevel5
Copy link

@jodosha my point is that the results of array_sort_by.rb are the same :| - it should be different right?

jodosha added a commit that referenced this pull request Dec 8, 2014
Fix lib/rack-patch.rb for MRI 2.2.0 and Rbx 2.3.0 on Ubuntu
@jodosha jodosha merged commit e3c93a1 into master Dec 8, 2014
@jodosha jodosha deleted the fix-rack-utils-mri-2-2-0 branch December 8, 2014 10:33
@jodosha
Copy link
Member Author

jodosha commented Dec 8, 2014

@JONESLEE85 they should be the same across all the Ruby versions and OS.
OS X has consistent results across Ruby 2.0 to 2.2.
Ubuntu has inconsistent results with 2.2. From 2.0 to 2.1 it works like OS X.

@runlevel5
Copy link

@jodosha that's right, it is only Linux-related. Have you lodged an error with Rack?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect Mime Type with MRI 2.2.0-preview1 on Ubuntu

3 participants