Eliminate undefined method []' for nil:NilClass` bug
#63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lessless I'm sorry that you closed this without having the chance to discuss together about this fix. Your will to "battle test" was and it's still precious. But in an project like Lotus with limited time and resources, we should take a side and prioritize things. Now that we have released it, we can all discuss on how to improve flash feature and to eventually promote it to public API. I hope you understand our constraints. Can you please expand this PR with a failing test? Thank you in advance. |
jodosha
added a commit
that referenced
this pull request
Jan 6, 2015
Eliminate `undefined method `[]' for nil:NilClass` bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should handle absence of :__flash key in the session hash. Obvious this is not a solution for the bug itself, but just a patch for dealing with consequences.
Closes #65