Adds underlying_type support to UnitVec including direct initialization #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-langholtz
added
Enhancement
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
louis-langholtz
force-pushed
the
updates-20240427
branch
2 times, most recently
from
7f396e4
to
05883d6
Compare
louis-langholtz
force-pushed
the
updates-20240427
branch
from
05883d6
to
03d1c95
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
louis-langholtz
force-pushed
the
updates-20240427
branch
from
03d1c95
to
fd5b993
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description - What's this PR do?
underlying_typesupport tod2::UnitVec.d2::UnitVecfor supporting initialization with values that are already unit vector values.Impacts/Risks of These Changes?
90-degree unit vectors aren't always absolutely 1 but within 2 ULPs of 1.
Related Issues