Develop zgh #3
Closed
Develop zgh #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-she
requested changes
May 20, 2019
louis-she
requested changes
May 24, 2019
minetorch/dockerize.py
Outdated
| docker_tag = img[0].tags[0] | ||
| # step 3 run local registry | ||
| print("step 3 begin") | ||
| client.containers.run(image='docker.io/registry:latest', detach=True, ports={'5000/tcp': 6000}) |
There was a problem hiding this comment.
这个只有第一次 build image 才需要吧？ 难道每次build 一个 image 都要去起个 docker registry？
There was a problem hiding this comment.
最好在起 Minetorch Server 的时候就把仓库 Server 也跑起来，默认每次 build image 的时候，仓库都是起了的
added 2 commits
May 26, 2019 14:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
newApi: /api/experiments/<experiment_id>/dockerimage
return imagename:tag of new build docker image