-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Historical Buildings + history cleaning #295
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
IhateTrains
commented
Jul 30, 2017
•
edited
Loading
edited
- Historical Buildings:
- Church of the Holy Sepulchre
- Temple of Zeus
- Golden Gate of Kiev
- Calat Alhambra
- Multiprovince Roman Limes
- Multiprovince Roman Roads
- tweaking
- updating positions for Constantinople
- finished character history cleaning from "a" to "i" cultures
- Adapted the anachronistic reference to Varangian Guards in the Chariot racing event from Legacy of Rome to be more fitting for the mod setting
merge from loup99
* further e_axum and Axum provinces history fixes + rulers of Axum fixes * removed 2 duplicates from MZ.csv (the same keys available in other file) * sound fixes * 1042276 character culture fix * other minor fixes
* Removed triggered modifiers, file renaming, misc - Removed all triggered modifiers from MZ. Most of the work had already been done by @TurtleShroom , but I added pre-triggers and used new name-spaces, as well as removed the old file. - Removed unused VIET cooldowns - Renamed VIET files - Added missing k_mimamsa code * Misc changes to court poet decision Added the discussed changes: - Moved the decision to the WtWSMS file - Recycled the vanilla event rather than adding the new ones
* Removed triggered modifiers, file renaming, misc - Removed all triggered modifiers from MZ. Most of the work had already been done by @TurtleShroom , but I added pre-triggers and used new name-spaces, as well as removed the old file. - Removed unused VIET cooldowns - Renamed VIET files - Added missing k_mimamsa code * Removed triggered modifiers, file renaming, misc (#33) - Removed all triggered modifiers from MZ. Most of the work had already been done by @TurtleShroom , but I added pre-triggers and used new name-spaces, as well as removed the old file. - Removed unused VIET cooldowns - Renamed VIET files - Added missing k_mimamsa code * experimenting * still trying * first issue fixed * I think it's finally done
Fixed Broken Cretan Feast Decision
Salerno in the Rule of Dukes fix
Senate Approval
loup99
approved these changes
Jul 31, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.