Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to define highlight start and end tag #70

Conversation

alexander-schranz
Copy link
Contributor

@alexander-schranz alexander-schranz commented Jan 30, 2024

Currently always <em></em> is used for the highlighted text but <mark></mark> or custom tags with classes are maybe in some cases used.

Currently looking into how to implement such things into SEAL: schranz-search/schranz-search#343

Copy link
Contributor

@Toflar Toflar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! ❤️ This is a new feature and should be rebased onto develop. There will be merge conflicts because there are already other improvements on highlighting for the next version 😊

@alexander-schranz alexander-schranz changed the base branch from main to develop January 31, 2024 10:02
@alexander-schranz alexander-schranz force-pushed the feature/configurable-highlight-start-end-tag branch from e3fd3e0 to 05b3c40 Compare January 31, 2024 13:39
@Toflar Toflar merged commit 8a0acbd into loupe-php:develop Jan 31, 2024
14 checks passed
@Toflar
Copy link
Contributor

Toflar commented Jan 31, 2024

Thanks @alexander-schranz !

@alexander-schranz alexander-schranz deleted the feature/configurable-highlight-start-end-tag branch January 31, 2024 16:03
@alexander-schranz
Copy link
Contributor Author

Nice, thx for the quick review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants