merge #3
Merged
merge #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it compatible with Spliterator/Stream in java8 by returning a new iterator each time iterator() is called
Fixed typos in README.md
Fix CompositeIterable
Given mutable nature of Packet object and a fact that single Packet instance is created in BroadcastOperations before sending it all clients, when event is emitted to room where clients with different namespaces are joined, then all of them will receive that event on single namespace. By using withNs method, Packet copy will be created, effectively, solving the issue
Fix cross-namespace broadcast happens on single ns
Add support for event interceptors which catch all events
In order to create custom serialization code (using `JsonSupport`) I need to be able to create `Event` classes
Make "Event" class public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.