New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Default for Output should be empty #6

Merged

lovell merged 1 commit into lovell:main from evayde:main

Dec 23, 2021

Contributor

evayde commented Dec 18, 2021

The default for output should be empty, so when no output is set then outdir = inputdir.

Otherwise this condition (convert.js) only has effect if output is manually set to empty via cmd (output=""):

  const outputPath = path.join(
    output ? output : path.dirname(input),
    outputFilename
  );


          fix: Default for Output should be empty

5dec1c3

evayde mentioned this pull request

Input directory should be default output directory #7

Closed

lovell merged commit 9cd0a6d into lovell:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment