Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate jstips to Chinese Translation version #241

Merged
merged 3 commits into from
Feb 21, 2016
Merged

Translate jstips to Chinese Translation version #241

merged 3 commits into from
Feb 21, 2016

Conversation

neighborhood999
Copy link
Collaborator

Hi @loverajoel
I very like jstips!That's simple and useful!
So I want to translate to Chinese Translation for my friends and other peoples for learning.
I will complete other config and something.

@loverajoel
Copy link
Owner

Hey @neighborhood999 what is the difference with this Chinese version? https://github.com/loverajoel/jstips/tree/gh-pages/_posts/zh_CN

@loverajoel
Copy link
Owner

@sjfkai ping!

@neighborhood999
Copy link
Collaborator Author

@loverajoel yep, different Chinese version is on diction and Chinese Translation is use by Taiwanese.

@sjfkai
Copy link
Collaborator

sjfkai commented Feb 14, 2016

yes, we need this version, and it should be called zh_TW. Some differences from zh_CN

@neighborhood999 neighborhood999 changed the title [WIP]Translate jstips to Chinese Translation version Translate jstips to Chinese Translation version Feb 14, 2016
@neighborhood999
Copy link
Collaborator Author

Hey @loverajoel, I already setting config, please check. thank you :)

@loverajoel
Copy link
Owner

@neighborhood999 sure, I will check it today, thanks!

@sjfkai
Copy link
Collaborator

sjfkai commented Feb 16, 2016

👍

@neighborhood999
Copy link
Collaborator Author

@loverajoel thank you!

@chentsulin
Copy link
Contributor

👍

@zenopopovici
Copy link
Collaborator

@sjfkai Please merge this if all looks ok.

@neighborhood999
Copy link
Collaborator Author

@zenopopovici thank you!

@sjfkai
Copy link
Collaborator

sjfkai commented Feb 20, 2016

@zenopopovici Please keep up with the newest tip.

And after finish that @loverajoel maybe you should merge this

@zenopopovici
Copy link
Collaborator

@sjfkai: will be more careful

@neighborhood999
Copy link
Collaborator Author

@sjfkai I already update to newest tips.

@loverajoel
Copy link
Owner

@neighborhood999 I will merge this weekend!

loverajoel added a commit that referenced this pull request Feb 21, 2016
Translate jstips to Chinese Translation version
@loverajoel loverajoel merged commit 5aea7dc into loverajoel:gh-pages Feb 21, 2016
@loverajoel
Copy link
Owner

@neighborhood999 I merged your PR, thanks for this huge work!

I will add you administrator and you will in charge to translate tips and update tips after improvements.

Please let me know if you have any question

@neighborhood999
Copy link
Collaborator Author

@loverajoel thank you for merge!
OK, It's no problem, I will update tips and improvements.

@loverajoel
Copy link
Owner

image

Impressive visitors yesterday

@zenopopovici
Copy link
Collaborator

Cool :)

@neighborhood999
Copy link
Collaborator Author

I post and share this website in my facebook group.
They are so happy have zh-TW lang version!
I'm really thanks @loverajoel let me merged my translate version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants