Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new rules #260

Merged
merged 5 commits into from
Feb 22, 2016
Merged

Add new rules #260

merged 5 commits into from
Feb 22, 2016

Conversation

loverajoel
Copy link
Owner

Update project guidelines

Based on comments in this issue I rewrite the rules.

Please feel free to add suggestions!

@kurtextrem
Copy link
Contributor

👍
By the way, now we can add issue and PR templates. Is that something we want?

@loverajoel
Copy link
Owner Author

@kurtextrem I added yesterday the PR template

@kurtextrem
Copy link
Contributor

Aah sorry :)
Am 19.02.2016 17:58 schrieb "Joel Lovera" notifications@github.com:

@kurtextrem https://github.com/kurtextrem I added yesterday the PR
template


Reply to this email directly or view it on GitHub
#260 (comment).

@loverajoel
Copy link
Owner Author

@zenopopovici haha 5 is better to me, we can try with 5 and if we see that it is much we can return to 3

# Introducing JavaScript Tips [![Awesome](https://cdn.rawgit.com/sindresorhus/awesome/d7305f38d29fed78fa85652e3a63e154dd8e8829/media/badge.svg)](https://github.com/sindresorhus/awesome)
> New year, new project. **A JS tip per day!**
# JS Tips [![Awesome](https://cdn.rawgit.com/sindresorhus/awesome/d7305f38d29fed78fa85652e3a63e154dd8e8829/media/badge.svg)](https://github.com/sindresorhus/awesome)
> A useful Js tip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe A useful JS tips?

@zenopopovici
Copy link
Collaborator

@loverajoel There are still some spelling mistakes suggested by @drakmail. Take a look when you have the time.

@loverajoel
Copy link
Owner Author

@drakmail fiexed, thanks!

@drakmail
Copy link
Contributor

:shipit:

1 similar comment
@zenopopovici
Copy link
Collaborator

:shipit:

@bmkmanoj
Copy link
Contributor

5 is good, :shipit:

@loverajoel
Copy link
Owner Author

Thanks guys!

loverajoel added a commit that referenced this pull request Feb 22, 2016
@loverajoel loverajoel merged commit c40e754 into gh-pages Feb 22, 2016
@loverajoel loverajoel deleted the joel_new_rules branch February 22, 2016 23:17
@kurtextrem
Copy link
Contributor

🎉 this is awesome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants