Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/move kafkamock #118

Merged
merged 3 commits into from
Apr 4, 2018
Merged

Feature/move kafkamock #118

merged 3 commits into from
Apr 4, 2018

Conversation

db7
Copy link
Collaborator

@db7 db7 commented Mar 27, 2018 •
edited
Loading

This PR refactors KafkaMock a bit.

  • KafkaMock is renamed as Tester since it mocks not only Kafka but also the storage
  • Tester is moved into tester subpackage
  • Goka accepts a tester interface as option in processors (that should be extended later for views too)
  • The ControllerMock in kafkamock.go is now in mock/controller.go
  • The old Tester type in kafkamock.go is now T since it wraps testing.T
  • The constructor of the tester.Tester does not require the group since that is passed to the consumer builder

@db7 db7 requested a review from frairon March 27, 2018 18:49
@frairon
Copy link
Contributor

frairon commented Apr 4, 2018

I added another test in the examples to check for emits.
@db7 please recheck.

@db7 db7 merged commit 8b40064 into master Apr 4, 2018
@db7 db7 deleted the feature/move-kafkamock branch April 4, 2018 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frairon frairon frairon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@db7 @frairon