Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[edn] Consider modifying FIFO instantiations #21155

Closed
vogelpi opened this issue Feb 1, 2024 · 2 comments · Fixed by #22599
Closed

[edn] Consider modifying FIFO instantiations #21155

vogelpi opened this issue Feb 1, 2024 · 2 comments · Fixed by #22599
Assignees
Labels
Component:RTL Component:Security Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones IP:edn Subsystem:Entropy entropy_src, csrng, or edn related issues

Comments

@vogelpi
Copy link
Contributor

vogelpi commented Feb 1, 2024

Description

When reviewing #21142, I notices that inside EDN the FIFO primitives are not hardened and they output zero when empty. This is not ideal and could be changed at low design, area and DV overhead. Each FIFO already has error signals used for detecting cases when an empty FIFO is popped etc.

@vogelpi vogelpi added Component:RTL Component:Security Subsystem:Entropy entropy_src, csrng, or edn related issues IP:edn Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones labels Feb 1, 2024
@vogelpi vogelpi added this to the Earlgrey-PROD.M3 milestone Feb 1, 2024
@andreaskurth
Copy link
Contributor

@vogelpi: It may not be possible to turn on hardening due to area optimizations, but we should disable output zero

vogelpi added a commit to vogelpi/opentitan that referenced this issue Apr 16, 2024
This resolves lowRISC#21155.

Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>
@vogelpi
Copy link
Contributor Author

vogelpi commented Apr 16, 2024

I turns out there are just two sync FIFOs that can be hardened and the area impact should be very low for both of them. I've filed a PR to do this here #22599.

rswarbrick pushed a commit to vogelpi/opentitan that referenced this issue Apr 17, 2024
This resolves lowRISC#21155.

Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>
vogelpi added a commit to vogelpi/opentitan that referenced this issue Apr 18, 2024
This resolves lowRISC#21155.

Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>
vogelpi added a commit to vogelpi/opentitan that referenced this issue Apr 18, 2024
This resolves lowRISC#21155.

Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>
vogelpi added a commit to vogelpi/opentitan that referenced this issue Apr 18, 2024
This resolves lowRISC#21155.

Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>
vogelpi added a commit that referenced this issue Apr 19, 2024
This resolves #21155.

Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:RTL Component:Security Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones IP:edn Subsystem:Entropy entropy_src, csrng, or edn related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants