This repository has been archived by the owner on May 26, 2023. It is now read-only.
Default event handlers are registered lazily on first call to event() #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $builder = new \Pheasant\SchemaBuilder(); | ||
| $initializer = $callback ? $callback : array($subject, 'initialize'); | ||
| $initializer = $callback ? $callback : $class.'::initialize'; |
There was a problem hiding this comment.
I wasn't sure why this was done in the first place. The initialize method should be static, creating an instance just to call the method seems wasteful and can cause infinite loops if fromArray calls initialize.
lox
added a commit
that referenced
this pull request
Mar 18, 2013
Default event handlers are registered lazily on first call to event()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in bug #30, the default event handlers weren't being created for objects created by
DomainObject::fromArray.The fix is to simply register them lazily, right after the first call to
DomainObject::events(), which is the gateway for the Events object.