This repository has been archived by the owner on May 26, 2023. It is now read-only.
Remaining things for pull-request 68 #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`orderBy()` replaces the existing ordering array. `andOrderBy()` adds an extra sorting key.
| */ | ||
| public function order($sql, $params=array()) | ||
| { | ||
| trigger_error("`order` is deprecated, use `orderBy` instead.", E_USER_NOTICE); |
There was a problem hiding this comment.
Let's drop the notice for now. I'll remove the method in the next version.
There was a problem hiding this comment.
Removed in commit ce227bb.
Please note that the function is still deprecated and usage is discouraged. Please use orderBy() instead.
|
Merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the mess with all those pull-requests.
Remaining commits for PR #68: See: #68 (comment)